Remove Microsoft.ServiceFabric.Internal references #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olegsych
force-pushed
the
user/olegsych/RemoveMicrosoftServiceFabricInternalDll
branch
from
2102f68 to
9921e79
Compare
gobradovic-MSFT
approved these changes
Aug 12, 2024
olegsych
force-pushed
the
user/olegsych/RemoveMicrosoftServiceFabricInternalDll
branch
from
6b159a6 to
7eac163
Compare
olegsych
force-pushed
the
user/olegsych/RemoveMicrosoftServiceFabricInternalDll
branch
from
7eac163 to
6f23227
Compare
yashagarwal23
approved these changes
Aug 21, 2024
gobradovic-MSFT
approved these changes
Aug 21, 2024
olegsych
deleted the
user/olegsych/RemoveMicrosoftServiceFabricInternalDll
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Microsoft.ServiceFabric.Internal.dllwas introduced years ago as an assembly meant to be used by the Service Fabric SDK packages instead of theSystem.Fabric.dll. TheMicrosoft.ServiceFabric.Internalassembly includes a subset of the types fromSystem.Fabricwith the exception of a few internal types.However, both of these DLLs are now included in the
Microsoft.ServiceFabricNuGet package and most Service Fabric .NET services, reference both of them. With the original intent abandoned, there is no clear value in keeping theMicrosoft.ServiceFabric.Internal.dll. Removing it from the Service Fabric Runtime and SDK eliminates the cost of maintaining it and reduces unnecessary complexity and cognitive load on the engineers.See Windows Fabric PR for more.