-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python: Introducing Google Search as a Text Search implementation #9691
Merged
eavanvalkenburg
merged 3 commits into
microsoft:main
from
eavanvalkenburg:google_text_search
Nov 14, 2024
Merged
Python: Introducing Google Search as a Text Search implementation #9691
eavanvalkenburg
merged 3 commits into
microsoft:main
from
eavanvalkenburg:google_text_search
Nov 14, 2024
+499
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markwallace-microsoft
added
the
python
Pull requests for the Python Semantic Kernel
label
Nov 13, 2024
TaoChenOSU
reviewed
Nov 13, 2024
python/semantic_kernel/connectors/search/google/google_search.py
Outdated
Show resolved
Hide resolved
python/semantic_kernel/connectors/search/google/google_search.py
Outdated
Show resolved
Hide resolved
python/semantic_kernel/connectors/search/google/google_search.py
Outdated
Show resolved
Hide resolved
python/semantic_kernel/connectors/search/google/google_search_settings.py
Outdated
Show resolved
Hide resolved
eavanvalkenburg
force-pushed
the
google_text_search
branch
from
November 14, 2024 08:36
6eb6594
to
ed6d152
Compare
markwallace-microsoft
approved these changes
Nov 14, 2024
python/semantic_kernel/connectors/search/google/google_search.py
Outdated
Show resolved
Hide resolved
moonbox3
approved these changes
Nov 14, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Nov 14, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Nov 14, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Nov 14, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Nov 14, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Nov 14, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Nov 14, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This adds a new version of the Google Search implementation based on the new Text Search interfaces.
Easily create a plugin from the different search functions to perform RAG with online docs!
Closes #6834
Description
Creates a new folder under connectors.search for Google.
Adds GoogleSearch
Adds classes to capture the response.
Adds constants for the query parameters
Adds a sample showing how to use it with a filter.
Contribution Checklist