-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
.Net Agents - Fix Aggregator Streaming for Nested Mode (#9669)
### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> Fixes: #8677 Aggretator agent not yielding content for streamed response when Mode=Nested. ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> Analyzed and addressed behavior and added integration tests. ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [X] The code builds clean without any errors or warnings - [X] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [X] All unit tests pass, and I have added new tests where possible - [X] I didn't break anyone 😄
- Loading branch information
Showing
2 changed files
with
181 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
173 changes: 173 additions & 0 deletions
173
dotnet/src/IntegrationTests/Agents/AggregatorAgentTests.cs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,173 @@ | ||
// Copyright (c) Microsoft. All rights reserved. | ||
using System; | ||
using System.Collections.Generic; | ||
using System.Linq; | ||
using System.Threading; | ||
using System.Threading.Tasks; | ||
using Azure.Identity; | ||
using Microsoft.Extensions.Configuration; | ||
using Microsoft.SemanticKernel; | ||
using Microsoft.SemanticKernel.Agents; | ||
using Microsoft.SemanticKernel.Agents.Chat; | ||
using Microsoft.SemanticKernel.ChatCompletion; | ||
using SemanticKernel.IntegrationTests.TestSettings; | ||
using xRetry; | ||
using Xunit; | ||
|
||
namespace SemanticKernel.IntegrationTests.Agents; | ||
|
||
#pragma warning disable xUnit1004 // Contains test methods used in manual verification. Disable warning for this file only. | ||
|
||
public sealed class AggregatorAgentTests() | ||
{ | ||
private readonly IKernelBuilder _kernelBuilder = Kernel.CreateBuilder(); | ||
private readonly IConfigurationRoot _configuration = new ConfigurationBuilder() | ||
.AddJsonFile(path: "testsettings.json", optional: true, reloadOnChange: true) | ||
.AddJsonFile(path: "testsettings.development.json", optional: true, reloadOnChange: true) | ||
.AddEnvironmentVariables() | ||
.AddUserSecrets<OpenAIAssistantAgentTests>() | ||
.Build(); | ||
|
||
/// <summary> | ||
/// Integration test for <see cref="AggregatorAgent"/> non-streamed nested response. | ||
/// </summary> | ||
[RetryFact(typeof(HttpOperationException))] | ||
public async Task AggregatorAgentFlatResponseAsync() | ||
{ | ||
// Arrange | ||
AggregatorAgent aggregatorAgent = new(() => this.CreateChatProvider()) | ||
{ | ||
Mode = AggregatorMode.Flat, | ||
}; | ||
|
||
AgentGroupChat chat = new(); | ||
chat.AddChatMessage(new ChatMessageContent(AuthorRole.User, "1")); | ||
|
||
// Act | ||
ChatMessageContent[] responses = await chat.InvokeAsync(aggregatorAgent).ToArrayAsync(); | ||
|
||
// Assert | ||
ChatMessageContent[] innerHistory = await chat.GetChatMessagesAsync(aggregatorAgent).ToArrayAsync(); | ||
Assert.Equal(6, innerHistory.Length); | ||
Assert.Equal(5, responses.Length); | ||
Assert.NotNull(responses[4].Content); | ||
Assert.True(responses[4].Content!.Contains("six", StringComparison.OrdinalIgnoreCase)); | ||
} | ||
|
||
/// <summary> | ||
/// Integration test for <see cref="AggregatorAgent"/> non-streamed nested response. | ||
/// </summary> | ||
[RetryFact(typeof(HttpOperationException))] | ||
public async Task AggregatorAgentNestedResponseAsync() | ||
{ | ||
// Arrange | ||
AggregatorAgent aggregatorAgent = new(() => this.CreateChatProvider()) | ||
{ | ||
Mode = AggregatorMode.Nested, | ||
}; | ||
|
||
AgentGroupChat chat = new(); | ||
chat.AddChatMessage(new ChatMessageContent(AuthorRole.User, "1")); | ||
|
||
// Act | ||
ChatMessageContent[] responses = await chat.InvokeAsync(aggregatorAgent).ToArrayAsync(); | ||
|
||
// Assert | ||
ChatMessageContent[] innerHistory = await chat.GetChatMessagesAsync(aggregatorAgent).ToArrayAsync(); | ||
Assert.Equal(6, innerHistory.Length); | ||
Assert.Single(responses); | ||
Assert.NotNull(responses[0].Content); | ||
Assert.True(responses[0].Content!.Contains("six", StringComparison.OrdinalIgnoreCase)); | ||
} | ||
|
||
/// <summary> | ||
/// Integration test for <see cref="AggregatorAgent"/> non-streamed response. | ||
/// </summary> | ||
[RetryFact(typeof(HttpOperationException))] | ||
public async Task AggregatorAgentFlatStreamAsync() | ||
{ | ||
// Arrange | ||
AggregatorAgent aggregatorAgent = new(() => this.CreateChatProvider()) | ||
{ | ||
Mode = AggregatorMode.Flat, | ||
}; | ||
|
||
AgentGroupChat chat = new(); | ||
chat.AddChatMessage(new ChatMessageContent(AuthorRole.User, "1")); | ||
|
||
// Act | ||
StreamingChatMessageContent[] streamedResponse = await chat.InvokeStreamingAsync(aggregatorAgent).ToArrayAsync(); | ||
|
||
// Assert | ||
ChatMessageContent[] fullResponses = await chat.GetChatMessagesAsync().ToArrayAsync(); | ||
ChatMessageContent[] innerHistory = await chat.GetChatMessagesAsync(aggregatorAgent).ToArrayAsync(); | ||
Assert.NotEmpty(streamedResponse); | ||
Assert.Equal(6, innerHistory.Length); | ||
Assert.Equal(6, fullResponses.Length); | ||
Assert.NotNull(fullResponses[0].Content); | ||
Assert.True(fullResponses[0].Content!.Contains("six", StringComparison.OrdinalIgnoreCase)); | ||
} | ||
|
||
/// <summary> | ||
/// Integration test for <see cref="AggregatorAgent"/> non-streamed response. | ||
/// </summary> | ||
[RetryFact(typeof(HttpOperationException))] | ||
public async Task AggregatorAgentNestedStreamAsync() | ||
{ | ||
// Arrange | ||
AggregatorAgent aggregatorAgent = new(() => this.CreateChatProvider()) | ||
{ | ||
Mode = AggregatorMode.Nested, | ||
}; | ||
|
||
AgentGroupChat chat = new(); | ||
chat.AddChatMessage(new ChatMessageContent(AuthorRole.User, "1")); | ||
|
||
// Act | ||
StreamingChatMessageContent[] streamedResponse = await chat.InvokeStreamingAsync(aggregatorAgent).ToArrayAsync(); | ||
|
||
// Assert | ||
ChatMessageContent[] fullResponses = await chat.GetChatMessagesAsync().ToArrayAsync(); | ||
ChatMessageContent[] innerHistory = await chat.GetChatMessagesAsync(aggregatorAgent).ToArrayAsync(); | ||
Assert.NotEmpty(streamedResponse); | ||
Assert.Equal(6, innerHistory.Length); | ||
Assert.Equal(2, fullResponses.Length); | ||
Assert.NotNull(fullResponses[0].Content); | ||
Assert.True(fullResponses[0].Content!.Contains("six", StringComparison.OrdinalIgnoreCase)); | ||
} | ||
|
||
private AgentGroupChat CreateChatProvider() | ||
{ | ||
// Arrange | ||
AzureOpenAIConfiguration configuration = this._configuration.GetSection("AzureOpenAI").Get<AzureOpenAIConfiguration>()!; | ||
|
||
this._kernelBuilder.AddAzureOpenAIChatCompletion( | ||
configuration.ChatDeploymentName!, | ||
configuration.Endpoint, | ||
new AzureCliCredential()); | ||
|
||
Kernel kernel = this._kernelBuilder.Build(); | ||
|
||
ChatCompletionAgent agent = | ||
new() | ||
{ | ||
Kernel = kernel, | ||
Instructions = "Your job is to count. Always add one to the previous number and respond using the english word for that number, without explanation.", | ||
}; | ||
|
||
return new AgentGroupChat(agent) | ||
{ | ||
ExecutionSettings = new() | ||
{ | ||
TerminationStrategy = new CountTerminationStrategy(5) | ||
} | ||
}; | ||
} | ||
|
||
private sealed class CountTerminationStrategy(int maximumResponseCount) : TerminationStrategy | ||
{ | ||
// Terminate when the assistant has responded N times. | ||
protected override Task<bool> ShouldAgentTerminateAsync(Agent agent, IReadOnlyList<ChatMessageContent> history, CancellationToken cancellationToken) | ||
=> Task.FromResult(history.Count(message => message.Role == AuthorRole.Assistant) >= maximumResponseCount); | ||
} | ||
} |