Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Table Header Row font weight #2924

Closed
wants to merge 5 commits into from

Conversation

juliaroldi
Copy link
Contributor

The default font-weight of the TH element overrides the font-weight of the segment. To resolve this, set the TH font-weight to normal when it has no predefined style. This way, when adding a header row to a table, the bold font-weight will be applied directly to the text segments.

Before the change the bold button was showing the wrong state.
image

After the change the bold button was showing the text is bold, as expected.
image

@juliaroldi juliaroldi marked this pull request as ready for review January 17, 2025 20:06
@JiuqingSong
Copy link
Collaborator

So in this way you moved bold format down to segments.

What if user turn off header after that?

@juliaroldi juliaroldi marked this pull request as draft January 22, 2025 20:08
@juliaroldi juliaroldi closed this Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants