Auto link enhancements #2798
Merged
Auto link enhancements #2798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliaroldi
requested review from
flyingbee2012,
BryanValverdeU,
JiuqingSong,
ianeli1,
vinguyen12 and
Andres-CT98
JiuqingSong
reviewed
Sep 16, 2024
|
|
||
| /** | ||
| * @internal | ||
| */ | ||
| export function createLink(editor: IEditor) { | ||
| export function createLink( | ||
| editor: IEditor, |
There was a problem hiding this comment.
Let's use an option object instead of multiple parameters. You can create an option type for createLink, then let AutoFormatOptions extend from it.
interface AutoLinkOptions {
autoLink?: boolean;
...
}
interface AutoFormatOptions extends AutoLinkOptions {
...
}| */ | ||
| export function getLinkUrl( | ||
| text: string, | ||
| shouldLink: boolean, |
| @@ -12,12 +12,15 @@ import type { | |||
| export function createLinkAfterSpace( | |||
| previousSegment: ContentModelText, | |||
| paragraph: ShallowMutableContentModelParagraph, | |||
| context: FormatContentModelContext | |||
| context: FormatContentModelContext, | |||
| autoLink: boolean, | |||
…u/juliaroldi/link-enhancements
JiuqingSong
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add to new options of auto transformation, automatically transform telephone numbers and email addresses in hyperlink. This change adds two new options
autoTelandautoMailto.