Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix table selector and resizer insertion #1984

Merged
merged 20 commits into from
Aug 1, 2023

Conversation

Andres-CT98
Copy link
Contributor

@Andres-CT98 Andres-CT98 commented Jul 27, 2023

Description:

Redo of #1919

The Table selector and resizer are currently inserted on the document, thus putting them on a different container to the table they belong to. This creates issues in some scenarios such as when a dialog is created above the document with a high z-index. They also have a fixed position which causes issues in some scrolling scenarios, where they stayed fixed in place instead of moving or disappearing.

Fix

Changed the insertion point of where the squares are located. The Selector and Resizer are inserted to where the Plugin specifies, if no selector is given it will default to the previous behaviour. The intent is for the selector to contain the editor. Additionally added a check for the resizer to not render if out of editor bounds.

Warnings and implications

  • The same scroll scenario where the squares remained on screen still remained due to the use of fixed position. Both operations are not functional, but it is a rare scenario to encounter.
  • The same issue exists in the table Inserters and cell resizers, which will be fixed the same way on a different PR. Fixed in Fix Cell resizers and Table Inserters #2007
  • The name of the Plugin 'TableResize' could be changed, as it is very similar to 'TableResizer' and is not descriptive of its full function..

@Andres-CT98 Andres-CT98 marked this pull request as ready for review July 28, 2023 22:10
@Andres-CT98 Andres-CT98 merged commit 457305f into master Aug 1, 2023
7 checks passed
@Andres-CT98 Andres-CT98 deleted the u/acampostams/fix-table-handles branch August 1, 2023 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants