Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Table Selection CSS Rule when selecting big table #1929

Merged
merged 4 commits into from
Jun 30, 2023

Conversation

BryanValverdeU
Copy link
Contributor

@BryanValverdeU BryanValverdeU commented Jun 29, 2023

It seems that the max amount of css selection length is 9000, so if we try to add styles for a massive table, the css rule is not enough.

In order to fix this, we should split the selectors in subsets where the css selector is less than 9000 characters,

Before
selectAllBefore

After
selectAlAfter

@BryanValverdeU BryanValverdeU merged commit 8ee97a1 into master Jun 30, 2023
7 checks passed
@BryanValverdeU BryanValverdeU deleted the u/bvalverde/fixTableSelectionStyles branch June 30, 2023 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants