Check the link format segment to turnoff (#1928)

microsoft · Jun 30, 2023 · cf85be5 · cf85be5
1 parent 5be7a7d
commit cf85be5
Show file tree

Hide file tree

Showing 2 changed files with 61 additions and 1 deletion.
diff --git a/...ges-content-model/roosterjs-content-model-editor/lib/publicApi/segment/toggleUnderline.ts b/...ges-content-model/roosterjs-content-model-editor/lib/publicApi/segment/toggleUnderline.ts
@@ -16,6 +16,6 @@ export default function toggleUnderline(editor: IContentModelEditor) {
                 segment.link.format.underline = !!isTurningOn;
             }
         },
-        format => !!format.underline
+        (format, segment) => !!format.underline || !!segment?.link?.format?.underline
     );
 }
diff --git a/...ontent-model/roosterjs-content-model-editor/test/publicApi/segment/toggleUnderlineTest.ts b/...ontent-model/roosterjs-content-model-editor/test/publicApi/segment/toggleUnderlineTest.ts
@@ -410,4 +410,64 @@ describe('toggleUnderline', () => {
             1
         );
     });
+
+    it('Turn off link', () => {
+        runTest(
+            {
+                blockGroupType: 'Document',
+                blocks: [
+                    {
+                        blockType: 'Paragraph',
+                        segments: [
+                            {
+                                segmentType: 'Text',
+                                text: 'Test',
+                                format: {},
+                                isSelected: true,
+                                link: {
+                                    format: {
+                                        href: 'https://microsoft.github.io/roosterjs/index.html',
+                                        anchorTitle: 'asd',
+                                        underline: true,
+                                    },
+                                    dataset: {},
+                                },
+                            },
+                        ],
+                        format: {},
+                    },
+                ],
+                format: {},
+            },
+            {
+                blockGroupType: 'Document',
+                blocks: [
+                    {
+                        blockType: 'Paragraph',
+                        segments: [
+                            {
+                                segmentType: 'Text',
+                                text: 'Test',
+                                format: {
+                                    underline: false,
+                                },
+                                isSelected: true,
+                                link: {
+                                    format: {
+                                        href: 'https://microsoft.github.io/roosterjs/index.html',
+                                        anchorTitle: 'asd',
+                                        underline: false,
+                                    },
+                                    dataset: {},
+                                },
+                            },
+                        ],
+                        format: {},
+                    },
+                ],
+                format: {},
+            },
+            1
+        );
+    });
 });