Merge pull request #1086 from microsoft/u/xiameng/fix-empty-range

Fix empty range
microsoft · Jul 14, 2022 · 2e9a643 · 2e9a643
2 parents 50b714b + 5c7f5f0
commit 2e9a643
Showing 1 changed file with 17 additions and 4 deletions.
diff --git a/packages/roosterjs-editor-core/lib/corePlugins/TypeInContainerPlugin.ts b/packages/roosterjs-editor-core/lib/corePlugins/TypeInContainerPlugin.ts
@@ -1,5 +1,5 @@
 import { EditorPlugin, IEditor, PluginEvent, PluginEventType } from 'roosterjs-editor-types';
-import { findClosestElementAncestor, Position } from 'roosterjs-editor-dom';
+import { findClosestElementAncestor, getTagOfNode, Position } from 'roosterjs-editor-dom';
 
 /**
  * @internal
@@ -30,6 +30,18 @@ export default class TypeInContainerPlugin implements EditorPlugin {
         this.editor = null;
     }
 
+    private isRangeEmpty(range: Range) {
+        if (
+            range.collapsed &&
+            range.startContainer.nodeType === Node.ELEMENT_NODE &&
+            getTagOfNode(range.startContainer) == 'DIV' &&
+            !range.startContainer.firstChild
+        ) {
+            return true;
+        }
+        return false;
+    }
+
     /**
      * Handle events triggered from editor
      * @param event PluginEvent object
@@ -47,9 +59,10 @@ export default class TypeInContainerPlugin implements EditorPlugin {
 
             if (
                 !range ||
-                this.editor.contains(
-                    findClosestElementAncestor(range.startContainer, null /* root */, '[style]')
-                )
+                (!this.isRangeEmpty(range) &&
+                    this.editor.contains(
+                        findClosestElementAncestor(range.startContainer, null /* root */, '[style]')
+                    ))
             ) {
                 return;
             }