Skip to content

Commit

Permalink
Content Model: Fix 221290 Support float for image
Browse files Browse the repository at this point in the history
  • Loading branch information
JiuqingSong committed Aug 4, 2023
1 parent d6a390c commit 1f8bc61
Show file tree
Hide file tree
Showing 9 changed files with 125 additions and 2 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
import { createTextFormatRenderer } from '../utils/createTextFormatRenderer';
import { FloatFormat } from 'roosterjs-content-model-types';
import { FormatRenderer } from '../utils/FormatRenderer';

export const FloatFormatRenderer: FormatRenderer<FloatFormat> = createTextFormatRenderer<
FloatFormat
>(
'Float',
format => format.float,
(format, value) => (format.float = value)
);
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import { ContentModelCodeView } from './ContentModelCodeView';
import { ContentModelImage, ContentModelImageFormat } from 'roosterjs-content-model-types';
import { ContentModelLinkView } from './ContentModelLinkView';
import { ContentModelView } from '../ContentModelView';
import { FloatFormatRenderer } from '../format/formatPart/FloatFormatRenderer';
import { FormatRenderer } from '../format/utils/FormatRenderer';
import { FormatView } from '../format/FormatView';
import { IdFormatRenderer } from '../format/formatPart/IdFormatRenderer';
Expand All @@ -22,6 +23,7 @@ const ImageFormatRenderers: FormatRenderer<ContentModelImageFormat>[] = [
...SizeFormatRenderers,
MarginFormatRenderer,
PaddingFormatRenderer,
FloatFormatRenderer,
];

export function ContentModelImageView(props: { image: ContentModelImage }) {
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
import { FloatFormat } from 'roosterjs-content-model-types';
import { FormatHandler } from '../FormatHandler';

/**
* @internal
*/
export const floatFormatHandler: FormatHandler<FloatFormat> = {
parse: (format, element) => {
const float = element.style.float || element.getAttribute('align');

if (float) {
format.float = float;
}
},
apply: (format, element) => {
if (format.float) {
element.style.float = format.float;
}
},
};
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import { boxShadowFormatHandler } from './common/boxShadowFormatHandler';
import { datasetFormatHandler } from './common/datasetFormatHandler';
import { directionFormatHandler } from './block/directionFormatHandler';
import { displayFormatHandler } from './block/displayFormatHandler';
import { floatFormatHandler } from './common/floatFormatHandler';
import { fontFamilyFormatHandler } from './segment/fontFamilyFormatHandler';
import { fontSizeFormatHandler } from './segment/fontSizeFormatHandler';
import { FormatHandler } from './FormatHandler';
Expand Down Expand Up @@ -58,6 +59,7 @@ const defaultFormatHandlerMap: FormatHandlers = {
dataset: datasetFormatHandler,
direction: directionFormatHandler,
display: displayFormatHandler,
float: floatFormatHandler,
fontFamily: fontFamilyFormatHandler,
fontSize: fontSizeFormatHandler,
htmlAlign: htmlAlignFormatHandler,
Expand Down Expand Up @@ -164,7 +166,17 @@ const defaultFormatKeysPerCategory: {
],
tableBorder: ['borderBox', 'tableSpacing'],
tableCellBorder: ['borderBox'],
image: ['id', 'size', 'margin', 'padding', 'borderBox', 'border', 'boxShadow', 'display'],
image: [
'id',
'size',
'margin',
'padding',
'borderBox',
'border',
'boxShadow',
'display',
'float',
],
link: [
'link',
'textColor',
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,60 @@
import { createDomToModelContext } from '../../../lib/domToModel/context/createDomToModelContext';
import { createModelToDomContext } from '../../../lib/modelToDom/context/createModelToDomContext';
import { DomToModelContext, FloatFormat, ModelToDomContext } from 'roosterjs-content-model-types';
import { floatFormatHandler } from '../../../lib/formatHandlers/common/floatFormatHandler';

describe('floatFormatHandler.parse', () => {
let div: HTMLElement;
let format: FloatFormat;
let context: DomToModelContext;

beforeEach(() => {
div = document.createElement('div');
format = {};
context = createDomToModelContext();
});

it('No float', () => {
floatFormatHandler.parse(format, div, context, {});
expect(format).toEqual({});
});

it('Float left', () => {
div.style.float = 'left';
floatFormatHandler.parse(format, div, context, {});
expect(format).toEqual({
float: 'left',
});
});

it('Float left from attribute', () => {
div.setAttribute('align', 'left');
floatFormatHandler.parse(format, div, context, {});
expect(format).toEqual({
float: 'left',
});
});
});

describe('floatFormatHandler.apply', () => {
let div: HTMLElement;
let format: FloatFormat;
let context: ModelToDomContext;

beforeEach(() => {
div = document.createElement('div');
format = {};
context = createModelToDomContext();
});

it('No float', () => {
floatFormatHandler.apply(format, div, context);
expect(div.outerHTML).toBe('<div></div>');
});

it('Float: left', () => {
format.float = 'left';
floatFormatHandler.apply(format, div, context);
expect(div.outerHTML).toBe('<div style="float: left;"></div>');
});
});
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import { BorderFormat } from './formatParts/BorderFormat';
import { BoxShadowFormat } from './formatParts/BoxShadowFormat';
import { ContentModelSegmentFormat } from './ContentModelSegmentFormat';
import { DisplayFormat } from './formatParts/DisplayFormat';
import { FloatFormat } from './formatParts/FloatFormat';
import { IdFormat } from './formatParts/IdFormat';
import { MarginFormat } from './formatParts/MarginFormat';
import { PaddingFormat } from './formatParts/PaddingFormat';
Expand All @@ -17,4 +18,5 @@ export type ContentModelImageFormat = ContentModelSegmentFormat &
PaddingFormat &
BorderFormat &
BoxShadowFormat &
DisplayFormat;
DisplayFormat &
FloatFormat;
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import { BoxShadowFormat } from './formatParts/BoxShadowFormat';
import { DatasetFormat } from './metadata/DatasetFormat';
import { DirectionFormat } from './formatParts/DirectionFormat';
import { DisplayFormat } from './formatParts/DisplayFormat';
import { FloatFormat } from './formatParts/FloatFormat';
import { FontFamilyFormat } from './formatParts/FontFamilyFormat';
import { FontSizeFormat } from './formatParts/FontSizeFormat';
import { HtmlAlignFormat } from './formatParts/HtmlAlignFormat';
Expand Down Expand Up @@ -74,6 +75,11 @@ export interface FormatHandlerTypeMap {
*/
display: DisplayFormat;

/**
* Format for FloatFormat
*/
float: FloatFormat;

/**
* Format for FontFamilyFormat
*/
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
/**
* Format of float
*/
export type FloatFormat = {
/**
* Float style
*/
float?: string;
};
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ export { SizeFormat } from './format/formatParts/SizeFormat';
export { BoxShadowFormat } from './format/formatParts/BoxShadowFormat';
export { ListThreadFormat } from './format/formatParts/ListThreadFormat';
export { ListStylePositionFormat } from './format/formatParts/ListStylePositionFormat';
export { FloatFormat } from './format/formatParts/FloatFormat';

export { DatasetFormat } from './format/metadata/DatasetFormat';
export { TableMetadataFormat } from './format/metadata/TableMetadataFormat';
Expand Down

0 comments on commit 1f8bc61

Please sign in to comment.