test: Retina e2e scale test #720
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timraymond
reviewed
Sep 10, 2024
| @@ -62,6 +62,20 @@ func DeleteTestInfra(subID, clusterName, location string) *types.Job { | |||
| return job | |||
| } | |||
|
|
|||
| func InstallRetina(kubeConfigFilePath, chartPath string) *types.Job { | |||
There was a problem hiding this comment.
Why do you need this? Can you refactor InstallAndTestRetinaBasicMetrics.
There was a problem hiding this comment.
I preferred not to change InstallAndTestRetinaBasicMetrics since this might be in use by someone else and the scope seems to be different.
The plan for the new pipeline is to Create Infra, Install Retina, Scale Up and Run Tests, so my thinking is to create different jobs for each stage so each job could be reused somewhere else. So in the future instead of using InstallAndTestRetinaBasicMetrics, one could [re-]use InstallRetina, Test Basic Metrics, and perhaps add some other set of tests. Does that make sense?
alexcastilio
force-pushed
the
create-scale-test-cluster
branch
from
7b88495
to
a853797
Compare
matmerr
reviewed
Sep 10, 2024
timraymond
reviewed
Sep 10, 2024
alexcastilio
force-pushed
the
create-scale-test-cluster
branch
4 times, most recently
from
04458ba
to
6662faf
Compare
Signed-off-by: Alex Castilio dos Santos <[email protected]>
alexcastilio
force-pushed
the
create-scale-test-cluster
branch
from
6662faf
to
69189ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Create Retina E2E Scale tests using test/e2e framework.
Related Issue
If this pull request is related to any issue, please mention it here. Additionally, make sure that the issue is assigned to you before submitting this pull request.
Checklist
git commit -S -s ...). See this documentation on signing commits.Screenshots (if applicable) or Testing Completed
Please add any relevant screenshots or GIFs to showcase the changes made.
Additional Notes
Add any additional notes or context about the pull request here.
Please refer to the CONTRIBUTING.md file for more information on how to contribute to this project.