-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(helm): Added support for affinity, readinessProbe and custom probes #696
Conversation
ad519d7
to
04de281
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @gciria, thanks for adding this support! Could you please rebase and resolve any conflicts?
04de281
to
7cc03c4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for this work @gciria! I would suggest in future to create an issue to discuss your enhancements proposals, so that the rationale behind the change is clear for everyone and also the work item can be added and eventually accepted in Retina Triage Board
@gciria can you sign your commit? https://retina.sh/docs/Contributing/developing#cryptographic-signing-of-commits |
7cc03c4
to
6239a26
Compare
|
Commit signed. Thanks |
Description
Added support for
affinity
,readinessProbe
andcustom probes
.Checklist
Screenshots (if applicable) or Testing Completed
Affinity:
Probes: