Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(helm): Added support for affinity, readinessProbe and custom probes #696

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

gciria
Copy link
Contributor

@gciria gciria commented Sep 3, 2024

Description

Added support for affinity, readinessProbe and custom probes.

Checklist

  • I have read the contributing documentation.
  • I have tested the changes locally.
  • I have followed the project's style guidelines.
  • I have updated the documentation, if necessary.
  • I have added tests, if applicable.

Screenshots (if applicable) or Testing Completed

Affinity:
retina-affinity

Probes:
retina-probes

Copy link
Member

@SRodi SRodi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @gciria, thanks for adding this support! Could you please rebase and resolve any conflicts?

@gciria
Copy link
Contributor Author

gciria commented Sep 25, 2024

Hi @gciria, thanks for adding this support! Could you please rebase and resolve any conflicts?

Hey @SRodi, I did the rebase and resolved the conflicts. Thanks a lot!

Copy link
Member

@SRodi SRodi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this work @gciria! I would suggest in future to create an issue to discuss your enhancements proposals, so that the rationale behind the change is clear for everyone and also the work item can be added and eventually accepted in Retina Triage Board

@ibezrukavyi ibezrukavyi self-requested a review September 25, 2024 12:54
@SRodi
Copy link
Member

SRodi commented Sep 25, 2024

@gciria
Copy link
Contributor Author

gciria commented Sep 25, 2024

thanks for this work @gciria! I would suggest in future to create an issue to discuss your enhancements proposals, so that the rationale behind the change is clear for everyone and also the work item can be added and eventually accepted in Retina Triage Board
Sure @SRodi ! Thanks for the feedback.

@gciria
Copy link
Contributor Author

gciria commented Sep 25, 2024

@gciria can you sign your commit? https://retina.sh/docs/Contributing/developing#cryptographic-signing-of-commits

Commit signed. Thanks

@ibezrukavyi ibezrukavyi added this pull request to the merge queue Sep 25, 2024
Merged via the queue into microsoft:main with commit a5f6f60 Sep 25, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants