fix(capture): remove only managed secret #653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mainred
changed the title
|
ping @rbtr and @timraymond to help take a look. |
timraymond
requested changes
Aug 27, 2024
mainred
force-pushed
the
fix-remove-secret
branch
from
dffd60a
to
e38f698
Compare
|
ping @timraymond for another review. |
Signed-off-by: Qingchuan Hao <[email protected]>
Signed-off-by: Qingchuan Hao <[email protected]>
mainred
force-pushed
the
fix-remove-secret
branch
from
f5c80e8
to
881fb32
Compare
timraymond
approved these changes
Sep 3, 2024
|
This PR will be closed in 7 days due to inactivity. |
github-actions
bot
added
the
meta/waiting-for-author
vakalapa
pushed a commit
that referenced
this pull request
Oct 9, 2024
# Description This change allows the operator to remove only the managed secret, and ignore NOTFOUND error. ## Related Issue If this pull request is related to any issue, please mention it here. Additionally, make sure that the issue is assigned to you before submitting this pull request. ## Checklist - [x] I have read the [contributing documentation](https://retina.sh/docs/contributing). - [x] I signed and signed-off the commits (`git commit -S -s ...`). See [this documentation](https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification) on signing commits. - [x] I have correctly attributed the author(s) of the code. - [x] I have tested the changes locally. - [x] I have followed the project's style guidelines. - [x] I have updated the documentation, if necessary. - [ ] I have added tests, if applicable. ## Screenshots (if applicable) or Testing Completed Please add any relevant screenshots or GIFs to showcase the changes made. - When removing the Capture with managed secret, it will delete the jobs and secret ``` ts=2024-08-26T07:51:27.757Z level=info caller=capture/controller.go:369 msg="Removing Capture" Capture=default/capture-pod-blobupload ts=2024-08-26T07:51:27.774Z level=info caller=capture/controller.go:387 msg="Capture jobs are removed" Capture=default/capture-pod-blobupload ts=2024-08-26T07:51:27.783Z level=info caller=capture/controller.go:402 msg="Capture secret is removed" Capture=default/capture-pod-blobupload Secret=managed-capture-pod-blobupload ``` - When removing the Capture with user owned secret, the secret will not be deleted ``` ts=2024-08-26T07:57:36.847Z level=info caller=capture/controller.go:369 msg="Removing Capture" Capture=default/capture-pod-blobupload ts=2024-08-26T07:57:36.862Z level=info caller=capture/controller.go:387 msg="Capture jobs are removed" Capture=default/capture-pod-blobupload ``` ## Additional Notes Add any additional notes or context about the pull request here. --- Please refer to the [CONTRIBUTING.md](../CONTRIBUTING.md) file for more information on how to contribute to this project. --------- Signed-off-by: Qingchuan Hao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change allows the operator to remove only the managed secret, and ignore NOTFOUND error.
Related Issue
If this pull request is related to any issue, please mention it here. Additionally, make sure that the issue is assigned to you before submitting this pull request.
Checklist
git commit -S -s ...). See this documentation on signing commits.Screenshots (if applicable) or Testing Completed
Please add any relevant screenshots or GIFs to showcase the changes made.
Additional Notes
Add any additional notes or context about the pull request here.
Please refer to the CONTRIBUTING.md file for more information on how to contribute to this project.