[Fabric] Implement maxFontSizeMultiplier in Text Input #14639
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anupriya13
added
Area: TextInput
Area: Fabric
anupriya13
added
the
AutoMerge
acoates-ms
reviewed
May 6, 2025
| @@ -128,6 +128,7 @@ struct WindowsTextInputComponentView | |||
| unsigned int m_imgWidth{0}, m_imgHeight{0}; | |||
| std::shared_ptr<facebook::react::WindowsTextInputShadowNode::ConcreteState const> m_state; | |||
| float m_fontSizeMultiplier{1.0}; | |||
| float m_maxFontSizeMultiplier{0.0}; | |||
There was a problem hiding this comment.
Let's not create duplicate members for all of the props. Instead, the property can be accessed using windowsTextInputProps().textAttributes.maxFontSizeMultiplier.
I think we should maybe hold off on this PR until the property exists on the props object.
There was a problem hiding this comment.
Sure we can wait when upstream changes are checked in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of Change
Why
What is the motivation for this change? Add a few sentences describing the context and overall goals of the pull request's commits.
[Fabric] Implement maxFontSizeMultiplier in Text Input
Resolves #14638
What
What changes were made to the codebase to solve the bug, add the functionality, etc. that you specified above.
[Fabric] Implement maxFontSizeMultiplier in Text Input
https://reactnative.dev/docs/textinput#maxfontsizemultiplier
Please note waiting for this PR to be merged from upstream to uncomment commented code: facebook/react-native@97cf42f
Implemented as per IOS and Android.
Refer https://github.com/facebook/react-native/blob/e69e35e370a7751d258905e3348fd2b0bb2e93c1/packages/react-native/Libraries/Text/RCTTextAttributes.mm#L249
Screenshots
Add any relevant screen captures here from before or after your changes.
Testing
If you added tests that prove your changes are effective or that your feature works, add a few sentences here detailing the added test scenarios.
Tested in playground and manipulating node_modules file code in TextAttributes.h
Changelog
Should this change be included in the release notes: indicate yes or no Yes
Add a brief summary of the change to use in the release notes for the next release.
[Fabric] Implement maxFontSizeMultiplier in Text Input