Skip to content

fix: event declartion and handler #929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: event declartion and handler #929

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions docs/native-modules.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ namespace NativeModuleSample
}

[ReactEvent]
public ReactEvent<double> AddEvent { get; set; }
public Action<double> AddEvent { get; set; }
}
}
```
Expand Down Expand Up @@ -497,12 +497,12 @@ class NativeModuleSample extends Component {

componentDidMount() {
// Subscribing to FancyMath.AddEvent
FancyMathEventEmitter.addListener('AddEvent', eventHandler, this);
FancyMathEventEmitter.addListener('AddEvent', this.eventHandler, this);
}

componentWillUnmount() {
// Unsubscribing from FancyMath.AddEvent
FancyMathEventEmitter.removeListener('AddEvent', eventHandler, this);
FancyMathEventEmitter.removeListener('AddEvent', this.eventHandler, this);
Comment on lines 498 to +505
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This part doesn't appear in the native sample code in the repo, just in the docs.
@jonthysell Is it expected to appear in https://github.com/microsoft/react-native-windows-samples/tree/main/samples/NativeModuleSample?

}

eventHandler(result) {
Expand Down