-
Notifications
You must be signed in to change notification settings - Fork 206
Add Fabric Component Props under API and Separate Old/New Components Section #1024
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add Fabric Component Props under API and Separate Old/New Components Section #1024
Conversation
@microsoft-github-policy-service agree company="Microsoft" |
Couple of small things:
|
website/.unbroken_exclusions
Outdated
@@ -17,6 +17,7 @@ | |||
!versioned_docs/version-0.76/native-api/*-api-windows*.md | |||
!versioned_docs/version-0.77/native-api/*-api-windows*.md | |||
!versioned_docs/version-0.78/native-api/*-api-windows*.md | |||
!versioned_docs/version-0.79/native-api/*-api-windows*.md |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah this is good question! We don't want to cut these documents yet, RNW 0.79 isn't released yet. Instead, this should just be changed in the next documentation (main) and we will create the 0.79 version-docs as part of the release process
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have removed them. Please review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We aren't ready to cut the 0.79 documentation, any changes/added documentation should be in the docs folder
|
Okay, maybe we can apply the suggestion from #1014 then, and mark each page depending on whether it is applicable to Old Arch, New Arch or both. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocking until design decision made about if we want to document all components instead of Windows-only.
Description
It doesn't contain Android / IOS specific props.
Why
What is the motivation for this change? Add a few sentences describing the context and overall goals of the pull request's commits.
Improve documentation
Resolves #1025
Refer https://github.com/facebook/react-native-website/blob/main/docs/image.md?plain=1
Screenshots
Add any relevant screen captures here from before or after your changes.
Before:
Recording.2025-04-19.234032.mp4
After: Added a new section which was missing in before "Windows Components - New Architecture"
website-new-vid.mp4
Microsoft Reviewers: Open in CodeFlow