chore: set up proper publishing pipeline #2266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tido64
force-pushed
the
tido/fix-publish
branch
2 times, most recently
from
a9fe079 to
c730181
Compare
Saadnajmi
reviewed
Nov 1, 2024
Saadnajmi
reviewed
Nov 1, 2024
tido64
force-pushed
the
tido/fix-publish
branch
5 times, most recently
from
a335e87 to
e4e70f3
Compare
tido64
force-pushed
the
tido/fix-publish
branch
12 times, most recently
from
ebed406 to
2a1da0e
Compare
Saadnajmi
reviewed
Nov 27, 2024
Saadnajmi
reviewed
Nov 28, 2024
Saadnajmi
reviewed
Nov 28, 2024
Saadnajmi
reviewed
Nov 28, 2024
Saadnajmi
approved these changes
Nov 28, 2024
There was a problem hiding this comment.
Thank you for this! Last ask, could we update this guide and/or write a new guide for how releases run / how to test releases locally? https://github.com/microsoft/react-native-macos/blob/main/docs/Releases.md
|
@Saadnajmi: Do you have access to the package in npm? We need to create/fix two tags,
(See PR description) Once they are fixed, this check should be green:
|
tido64
force-pushed
the
tido/fix-publish
branch
3 times, most recently
from
51c59b5 to
cd4104a
Compare
I do, I'll look into that |
tido64
force-pushed
the
tido/fix-publish
branch
from
2c74778 to
4f076ee
Compare
Saadnajmi
added a commit
to Saadnajmi/react-native-macos
that referenced
this pull request
Dec 4, 2024
* chore: set up proper publishing pipeline * simplify configuration and added docs * more docs * add TODO for nightlies * typos * also verify ADO pipeline * refactor checks * docs --------- Co-authored-by: Saad Najmi <[email protected]>
Saadnajmi
added a commit
that referenced
this pull request
Dec 4, 2024
* chore: set up proper publishing pipeline (#2266) * chore: set up proper publishing pipeline * simplify configuration and added docs * more docs * add TODO for nightlies * typos * also verify ADO pipeline * refactor checks * docs --------- Co-authored-by: Saad Najmi <[email protected]> * Update publish config * Fixup versions across monorepo * Add a version plan file to patch RNM * pre-run `set-rn-artifacts-version.js` sicne nx-release will not. --------- Co-authored-by: Tommy Nguyen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Sets up a publishing pipeline with Nx Release.
Note that while this does enable us to publish nightlies, it will be handled separately from this PR.
nightlytag to latest nightly build (npm)nexttag and point it to latest build (npm)Test Plan:
Follow the instructions in the releases docs and verify that they work for you: https://github.com/microsoft/react-native-macos/blob/cd4104ac8fbca08d60829cef56eed66b56b7d49d/docs/Releases.md