Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react-native): implement projectConfig and dependencyConfig (#2231) #2234

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

tido64
Copy link
Member

@tido64 tido64 commented Oct 23, 2024

Summary:

Implements projectConfig and dependencyConfig so that react-native config populates the macos field.

Cherry-picks #2231

Test Plan:

react-native config should populate the macos field. Example:

[...]
  "project": {
    "visionos": {
      "sourceDir": "/~/example/visionos",
      "xcodeProject": null,
      "assets": []
    },
    "ios": {
      "sourceDir": "/~/example/ios",
      "xcodeProject": {
        "name": "Example.xcworkspace",
        "path": ".",
        "isWorkspace": true
      },
      "automaticPodsInstallation": false,
      "assets": []
    },
    "android": {
      "sourceDir": "/~/example/android",
      "appName": "app",
      "packageName": "com.microsoft.reacttestapp",
      "applicationId": "com.microsoft.reacttestapp",
      "mainActivity": "com.microsoft.reacttestapp.MainActivity",
      "assets": []
    },
    "macos": {
      "sourceDir": "/~/example/macos",
      "xcodeProject": {
        "name": "Example.xcworkspace",
        "path": ".",
        "isWorkspace": true
      },
      "assets": []
    },
    "windows": null
  }
}

@Saadnajmi Saadnajmi merged commit 5b7837e into 0.74-stable Oct 23, 2024
11 of 13 checks passed
@Saadnajmi Saadnajmi deleted the tido/0.74/implement-getconfig branch October 23, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants