Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add grammar docstrings to QASM3 parser #2222

Merged
merged 7 commits into from
Mar 12, 2025
Merged

Add grammar docstrings to QASM3 parser #2222

merged 7 commits into from
Mar 12, 2025

Conversation

orpuente-MS
Copy link
Contributor

@orpuente-MS orpuente-MS commented Mar 11, 2025 •
edited
Loading

This PR:

  1. Fixes a bug with block statements
  2. Adds grammar docstrings to the QASM3 parser.
  3. Adds the invalid tests in the reference parser to make sure they are invalid for our parser as well.

@idavis idavis mentioned this pull request Mar 11, 2025
Draft
@idavis idavis merged commit 0a6afbb into feature/qasm3 Mar 12, 2025
15 checks passed
@idavis idavis deleted the oscarpuente/add-parser-grammar-docstrings branch March 12, 2025 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@idavis idavis idavis approved these changes

@minestarks minestarks Awaiting requested review from minestarks minestarks is a code owner

@swernli swernli Awaiting requested review from swernli swernli is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@orpuente-MS @idavis