Added SimpleBellPair sample #2213
Open
+46
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DmitryVasilevsky
requested review from
minestarks,
swernli,
billti and
idavis
as code owners
added 3 commits
March 5, 2025 14:02
ScottCarda-MS
approved these changes
Mar 5, 2025
There was a problem hiding this comment.
We have simple bell pair generation in the algorithms/entanglement.qs. How about renaming that to entanglement-simple-bell-pair.qs? That way we improve searchability and avoid redundancy. Thoughts?
There was a problem hiding this comment.
Thanks, good observation. I still think that we need a separate sample for discoverability and AI training. But we may need to adjust entanglement sample. We'll discuss.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are now missing a simple Bell pair sample. This pull request adds one.
As this will likely be one of the first samples people encounter, please make sure that it is simple enough while reviewing.