Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix run button disable. Switching to tutorial and back to samples (#1849) #2206

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

thecoder93
Copy link

@thecoder93 thecoder93 commented Mar 4, 2025

Hi, This should fix the problem #1849
I think that the first time the model is created and then the get is done. For samples kataSection is undefined and I don't know why the EntryPoint is missing. What do you think? Probably it's only a workaround.

@thecoder93 thecoder93 marked this pull request as draft March 5, 2025 13:24
@thecoder93
Copy link
Author

I saw that this workaround is not good, because there are same kata into different editor. I will work on it.

@thecoder93
Copy link
Author

I understood. From Monaco doc: Each model is identified by a URI. This is why it's not possible for two models to have the same URI.

Currently, we don't have the IDs for samples. Do you think to add it? I see also missing the structured type for Sample under npm/qsharp and the relative getAll such as Katas.
I think that with this we could have the independent ids for katas and Samples, thus when we do getModel from Monaco we get properly id.

@thecoder93 thecoder93 marked this pull request as ready for review March 7, 2025 16:59
@thecoder93
Copy link
Author

After several tests, I noticed a side effect when using updateDocument. Then the file is not closed with closeDocument. This should solve the problem. I think independent uri are therefore not necessary, or they would be an NTH.
What do you think?

@billti @minestarks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant