Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running npm audit fix --force #8491

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Running npm audit fix --force #8491

wants to merge 2 commits into from

Conversation

abchatra
Copy link
Collaborator

No description provided.

@riknoll
Copy link
Member

riknoll commented Sep 15, 2021

hmmmm... looks like this broke our testing code

@@ -62,24 +62,24 @@
"browserify": "16.2.0",
"chai": "^3.5.0",
"cssnano": "4.1.10",
"dompurify": "2.0.8",
"dompurify": "^2.3.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have a package-lock.json, so version numbers should not be loose matches; no ^, ~, etc. We need to ensure that the build machine uses the same package versions we developed with and tested locally. Why are we not using package-lock.json here?

Copy link
Contributor

@eanders-ms eanders-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lock version numbers or introduce package-lock.json. Otherwise we don't know what we're shipping.

@abchatra
Copy link
Collaborator Author

Some of these are test only like karma & mocha. We should be ok without exact versions right?

@eanders-ms
Copy link
Contributor

Some of these are test only like karma & mocha. We should be ok without exact versions right?

Sure, but would it not be simpler to lock them all? My preference would be to add a package-lock file actually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants