-
Notifications
You must be signed in to change notification settings - Fork 581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Running npm audit fix --force #8491
base: master
Are you sure you want to change the base?
Conversation
hmmmm... looks like this broke our testing code |
@@ -62,24 +62,24 @@ | |||
"browserify": "16.2.0", | |||
"chai": "^3.5.0", | |||
"cssnano": "4.1.10", | |||
"dompurify": "2.0.8", | |||
"dompurify": "^2.3.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't have a package-lock.json, so version numbers should not be loose matches; no ^
, ~
, etc. We need to ensure that the build machine uses the same package versions we developed with and tested locally. Why are we not using package-lock.json here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lock version numbers or introduce package-lock.json. Otherwise we don't know what we're shipping.
Some of these are test only like karma & mocha. We should be ok without exact versions right? |
Sure, but would it not be simpler to lock them all? My preference would be to add a package-lock file actually. |
No description provided.