Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix extra render trigger when initializing expandable blocks #10312

Merged
merged 1 commit into from
Dec 10, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions pxtblocks/composableMutations.ts
Original file line number Diff line number Diff line change
Expand Up @@ -345,9 +345,18 @@ export function initExpandableBlock(info: pxtc.BlocksInfo, b: Blockly.Block, def
Blockly.Events.disable();

try {
const nb = Blockly.Xml.domToBlock(shadow, b.workspace);
if (nb) {
input.connection.connect(nb.outputConnection);
let newBlock: Blockly.Block;
if (!b.initialized) {
// use domToBlockInternal so that we don't trigger a render while
// the block is still being initialized
newBlock = Blockly.Xml.domToBlockInternal(shadow, b.workspace);
}
else {
newBlock = Blockly.Xml.domToBlock(shadow, b.workspace);
}

if (newBlock) {
input.connection.connect(newBlock.outputConnection);
}
} catch (e) { }

Expand Down
Loading