Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace a few buttons with links #10256

Merged
merged 3 commits into from
Nov 4, 2024
Merged

Conversation

riknoll
Copy link
Member

@riknoll riknoll commented Nov 1, 2024

fixes https://github.com/microsoft/pxt-minecraft/issues/2483
fixes https://github.com/microsoft/pxt-minecraft/issues/2482

programmatically opening links in minecraft on macos doesn't work for whatever reason. clicking on <a /> elements does, so converting some buttons over to links. frankly, they should have been links in the first place for accessibility reasons.

this also fixes a css bug that was bothering me in the extension dialog where extension card titles were wrapping.

@riknoll riknoll requested a review from a team November 1, 2024 18:24
@riknoll riknoll merged commit b78814b into master Nov 4, 2024
5 checks passed
@riknoll riknoll deleted the dev/riknoll/buttons-to-links branch November 4, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants