Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

let editor extensions contribute experiments #10252

Merged
merged 4 commits into from
Oct 31, 2024

Conversation

riknoll
Copy link
Member

@riknoll riknoll commented Oct 31, 2024

part two of my master plan to allow you to copy logs in minecraft.

allows targets to add experiments to the experiments dialog. in this case, we'll be adding an experiment that copies logs to your clipboard.

also adds support for experiment cards that act like buttons rather than toggles, and passes the showNotification function to editor extensions so that we can show toasts

@riknoll riknoll requested a review from a team October 31, 2024 17:10
Copy link
Contributor

@srietkerk srietkerk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just have a couple of questions.

This change is only providing the infrastructure to let the editors add extensions, correct?
When you say that you're planning on copying logs to the clipboard, will it be every log? Will the extension just overload your clipboard?

@riknoll
Copy link
Member Author

riknoll commented Oct 31, 2024

@thsparks @srietkerk I accidentally left out a commit adding the log level to the Logger interface. please take a look!

@srietkerk yes, this does not include the actual experiment stuff (that pr will be on pxt-minecraft). as for copying every log, let's discuss this in the pxt-minecraft pr.

Copy link
Contributor

@thsparks thsparks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@riknoll riknoll merged commit ce89ae0 into master Oct 31, 2024
6 checks passed
@riknoll riknoll deleted the dev/riknoll/editor-extension-experiments branch October 31, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants