fix extra render trigger when initializing expandable blocks (#10312)

microsoft · Dec 10, 2024 · 2508354 · 2508354
1 parent 82c0eaf
commit 2508354
Showing 1 changed file with 12 additions and 3 deletions.
diff --git a/pxtblocks/composableMutations.ts b/pxtblocks/composableMutations.ts
@@ -345,9 +345,18 @@ export function initExpandableBlock(info: pxtc.BlocksInfo, b: Blockly.Block, def
         Blockly.Events.disable();
 
         try {
-            const nb = Blockly.Xml.domToBlock(shadow, b.workspace);
-            if (nb) {
-                input.connection.connect(nb.outputConnection);
+            let newBlock: Blockly.Block;
+            if (!b.initialized) {
+                // use domToBlockInternal so that we don't trigger a render while
+                // the block is still being initialized
+                newBlock = Blockly.Xml.domToBlockInternal(shadow, b.workspace);
+            }
+            else {
+                newBlock = Blockly.Xml.domToBlock(shadow, b.workspace);
+            }
+
+            if (newBlock) {
+                input.connection.connect(newBlock.outputConnection);
             }
         } catch (e) { }