Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bitmap rename #5983

Merged
merged 4 commits into from
Oct 9, 2024
Merged

Bitmap rename #5983

merged 4 commits into from
Oct 9, 2024

Conversation

tballmsft
Copy link
Contributor

@tballmsft tballmsft commented Oct 9, 2024 •
edited
Loading

renaming namespace "bitmap" to "bitmaps" so we can have top-level variables (for blocks) named "bitmap".

@tballmsft tballmsft marked this pull request as draft October 9, 2024 02:20
@tballmsft tballmsft marked this pull request as ready for review October 9, 2024 02:45
@tballmsft tballmsft requested a review from eanders-ms October 9, 2024 02:45
eanders-ms
eanders-ms approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@eanders-ms eanders-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice this hasn't shipped yet. No need to be concerned about breaking existing projects.

@tballmsft
Copy link
Contributor Author

correct. we are in beta for a bit...

@tballmsft tballmsft merged commit b800871 into master Oct 9, 2024
6 checks passed
@tballmsft tballmsft deleted the bitmapRename branch October 9, 2024 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eanders-ms eanders-ms eanders-ms approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tballmsft @eanders-ms