Remove stale sections approveRepos & preferredRepos #5401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwunderl
approved these changes
Nov 9, 2023
There was a problem hiding this comment.
LGTM, I don't think this will actually break old editors though cause we append version info to targetconfig request and I think it grabs based of major version? e.g.
https://makecode.microbit.org/api/config/microbit/targetconfig/v2.0.18 is the request made for /v2
|
pxt-jacdac is still marked as an approved extension --> pxt-microbit/targetconfig.json Line 309 in f2c964d |
|
Those are old sections and not read by the client. New sections should have all pxt-jacdac. |
THEb0nny
added a commit
to THEb0nny/pxt-ev3
that referenced
this pull request
Feb 10, 2024
We have new section approvedRepoLib which handles this. microsoft/pxt-microbit#5401
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have new section approvedRepoLib which handles this.
This will break extensions in old editors such as v4/v3 etc. We don't care about it at this point of time as they have workaround of adding extensions manually.