-
Notifications
You must be signed in to change notification settings - Fork 639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extension: add pxt-blelog #5202
base: master
Are you sure you want to change the base?
Conversation
@martinwork Yes with only one block there is no support for subcategory. You can denote V2 only in the image of the extension similar to data logger. Is the error question for me? |
@abchatra @abchatra @bsiever Maybe it is not expected that the user chooses passkey, but what happens if they do seems broken and leads to code loss. I didn't try clicking Remove this! @bsiever @bsiever |
I had already updated the tile text to indicate micro:bit (V2) (thanks to @martinwork's earlier concern about it), but I've updated the icon now too. Thanks to some guidance from Martin, I've tried switching from yotta-based BLE settings. Unfortunately, there seem to be some quirks I haven't yet resolved. For the time being I'm leaving the yotta settings. I'll look into it more as time permits. I hope to switch to the CODAL approach when I understand what's different. Details are below, but perhaps aren't relevant to this PR. Yotta config:
For CODAL-based settings I've tried both:
and:
I need to do more testing and review, but neither worked quite like the yotta approach. I think the simple "open" led the micro:bit to show up as two bluetooth devices (one for pairing and one not). The CODAL approaches both also seemed to default to operating-system level pairing when I tried to connect. That can lead to a bad user experience following updates to the code (inconsistent connection behaviors). I'm still looking into how the yotta settings are translated into configuration options, but I'm at the end of my allocated "play time" today 😞, so I'll come back to it later. |
Arising from https://support.microbit.org/helpdesk/tickets/63434 (private)
@bsiever
https://makecode.microbit.org/_34pTvM91Jb7F
@abchatra
The block was intended to appear under group heading "micro:bit (V2)", but it seems this is not possible with a single block.
pxt-microbit/libs/datalogger/datalogger.ts
Line 284 in 6c8fff5
The extension has a yotta definition for open security
https://github.com/bsiever/pxt-blelog/blob/master/pxt.json#L43
This is not reflected in Project Settings and the user choice seems to be ignored, unless I choose passkey security, and look at settings as text - then there is a brief red error message (conflict on yotta setting...), followed by this:
Extension repo: https://github.com/bsiever/pxt-blelog