Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fundamental] Add CG in compliance check CI to avoid license issue #3517

Draft
wants to merge 25 commits into
base: main
Choose a base branch
from

Conversation

zhengfeiwang
Copy link
Contributor

@zhengfeiwang zhengfeiwang commented Jul 9, 2024

Description

This PR targets to add CG (Component Governance, link to doc) step in compliance check, so that we can find inappropriate dependency introduced, as #3513 raises, during PR review and avoid change merged without caution.

Note that CG currently does not support detection from pyproject.toml file, so we leverage Python package toml-to-requirements to convert toml files to supported requirements.txt.

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@zhengfeiwang zhengfeiwang changed the title [fundamental] add workflow to check licenses compliance [fundamental] Add workflow as CI to check licenses compliance Jul 9, 2024
@zhengfeiwang zhengfeiwang changed the title [fundamental] Add workflow as CI to check licenses compliance [fundamental] Add CG in compliance check CI to avoid license issue Jul 11, 2024
Copy link

promptflow SDK CLI Azure E2E Test Result zhengfei/license-compliance

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 0923bce.

Copy link

SDK CLI Global Config Test Result zhengfei/license-compliance

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 0923bce.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant