docs: clarify the docs on deploying presidio to k8s #1453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omri374
reviewed
Sep 19, 2024
| @@ -40,8 +40,8 @@ You can install Presidio locally using [KIND](https://github.com/kubernetes-sigs | |||
|
|
|||
| 1. A Kubernetes 1.18+ cluster with [RBAC](https://kubernetes.io/docs/reference/access-authn-authz/rbac/) enabled. If you are using [AKS](https://docs.microsoft.com/en-us/azure/aks/intro-kubernetes) RBAC is enabled by default. | |||
|
|
|||
| !!! note: Note | |||
| Note the pod's resources requirements (CPU and memory) and plan the cluster accordingly. | |||
| > **NOTE**: | |||
There was a problem hiding this comment.
This is intentional. mkdocs then renders this as a colored box
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
The documentation on deploying Presidio to K8S with Helm is outdated and doesn't work. This PR fixes the documentation to a more expanded version for deploying through Helm.
Note
The note syntax of mkdocs is not supported by the linter. This PR also changes the notes on the page slightly so that the linter does not complain, and notes still show up correct in mkdocs.
Checklist
[ ] My code includes unit tests