-
Notifications
You must be signed in to change notification settings - Fork 565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added logic to handle phonenumbers with country code #1426
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks! Can you please add unit tests to this new functionality? There is a test_phone_number_recpgnizer.py file you could add tests to. |
Yes, sure! I will take care of that. |
Hi @omri374 I have added test case for the PR |
omri374
reviewed
Aug 2, 2024
/azp run |
omri374
approved these changes
Aug 2, 2024
Azure Pipelines successfully started running 1 pipeline(s). |
@kaushikabhishek87 we have a non-related issue with our CI. Working on it. |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Hi, long time user but first time contributing. Happy to learn & correct if something required. This is a minor change that a bug that I reported. The currently used phonenumbers.PhoneNumberMatcher function doesn't handle phone number starting with country code, the fucntion docstring (below) says to use different "region" parameter for such phone numbers.
Added code handles such phone number separately & resolves the mentioned bug.
Issue reference
This PR fixes issue #1425
Checklist