Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

closing handles #1424

Merged
merged 1 commit into from
Jul 29, 2024
Merged

closing handles #1424

merged 1 commit into from
Jul 29, 2024

Conversation

roeybc
Copy link
Collaborator

@roeybc roeybc commented Jul 29, 2024 •
edited
Loading

Change Description

Describe your changes

Issue reference

This PR fixes issue #XX

Checklist

  • I have reviewed the contribution guidelines
  • I have signed the CLA (if required)
  • My code includes unit tests
  • All unit tests and lint checks pass locally
  • My PR contains documentation updates / additions if required

omri374
omri374 approved these changes Jul 29, 2024
View reviewed changes
Copy link
Contributor

@omri374 omri374 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

@omri374 omri374 merged commit 2fe6ad7 into main Jul 29, 2024
32 checks passed
@omri374 omri374 deleted the bugfix/closing_handles branch July 29, 2024 09:35
@hhobson hhobson mentioned this pull request Aug 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omri374 omri374 omri374 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@roeybc @omri374