Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Analysis builder improvements #1295

Merged
merged 8 commits into from
Feb 15, 2024
Merged

Analysis builder improvements #1295

merged 8 commits into from
Feb 15, 2024

Conversation

ebotiab
Copy link
Contributor

@ebotiab ebotiab commented Feb 13, 2024

Issue reference

This PR fixes issue #1294

Checklist

  • I have reviewed the contribution guidelines
  • I have signed the CLA (if required)
  • My code includes unit tests
  • All unit tests and lint checks pass locally
  • My PR contains documentation updates / additions if required

@omri374
Copy link
Contributor

omri374 commented Feb 13, 2024

Thanks!

@omri374
Copy link
Contributor

omri374 commented Feb 13, 2024

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@omri374 omri374 self-requested a review February 13, 2024 15:02
@ebotiab
Copy link
Contributor Author

ebotiab commented Feb 13, 2024

Fixed lint error

@ebotiab
Copy link
Contributor Author

ebotiab commented Feb 14, 2024

Add other minor fixes of type hints

@omri374
Copy link
Contributor

omri374 commented Feb 15, 2024

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Jakob-98
Jakob-98 approved these changes Feb 15, 2024
View reviewed changes
Copy link
Collaborator

@Jakob-98 Jakob-98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for the improvement!
Nice work on finding the case where the data in recursive _get_nested_value calls can be None.

@omri374 omri374 merged commit 5dfbf27 into microsoft:main Feb 15, 2024
31 checks passed
@ebotiab ebotiab deleted the analysis-builder-improvements branch February 15, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jakob-98 Jakob-98 Jakob-98 approved these changes

@omri374 omri374 Awaiting requested review from omri374

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ebotiab @omri374 @Jakob-98