DICOM redactor improvement: Enable selection of redact approach #1113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omri374
reviewed
Jul 9, 2023
presidio-image-redactor/presidio_image_redactor/dicom_image_redactor_engine.py
Outdated
Show resolved
Hide resolved
presidio-image-redactor/presidio_image_redactor/dicom_image_redactor_engine.py
Outdated
Show resolved
Hide resolved
SharonHart
reviewed
Jul 9, 2023
presidio-image-redactor/presidio_image_redactor/dicom_image_redactor_engine.py
Outdated
Show resolved
Hide resolved
SharonHart
reviewed
Jul 9, 2023
presidio-image-redactor/presidio_image_redactor/dicom_image_redactor_engine.py
Outdated
Show resolved
Hide resolved
…etadata and ability to pass in ad_hoc_recognizers
This was referenced Aug 17, 2023
omri374
approved these changes
Aug 20, 2023
presidio-image-redactor/presidio_image_redactor/dicom_image_redactor_engine.py
Show resolved
Hide resolved
ayabel
approved these changes
Aug 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
In the current state, the DICOM image redactor automatically uses the metadata to create a custom recognizer to assist in analyzing words to redact. However, this may not always be the best approach.
This PR introduces changes which allow the user to toggle whether they want to use the DICOM metadata and also allows them to easily pass in
ad_hoc_recognizersto use for analysis.Issue reference
This PR fixes issue #XX
Checklist