Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DICOM redactor improvement: Enabling more photometric interpretations #1103

Merged
merged 2 commits into from
Jul 6, 2023

Conversation

niwilso
Copy link
Collaborator

@niwilso niwilso commented Jul 3, 2023

Change Description

The current version of the DICOM redactor only supports RGB and MONOCHROME images. This change enables the redactor to work with more photometric interpretations (e.g., YBR).

We also make one small change to safeguard against overwriting locally generated files via using a uuid rather than a hard-coded temporary file name string.

Issue reference

This PR fixes issue #967

Checklist

  • I have reviewed the contribution guidelines
  • I have signed the CLA (if required)
  • My code includes unit tests
  • All unit tests and lint checks pass locally
  • My PR contains documentation updates / additions if required

@niwilso niwilso marked this pull request as ready for review July 3, 2023 17:18
@niwilso niwilso merged commit 42f30bd into main Jul 6, 2023
23 checks passed
@omri374 omri374 deleted the niwilso/dicom/check-greyscale-bug branch October 25, 2023 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants