Skip to content
This repository has been archived by the owner on Nov 16, 2023. It is now read-only.

Issue 24 and 16 fixed #46

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

joelpires
Copy link

@joelpires joelpires commented Jan 4, 2020

  • the minor Issue 24 is fixed.
  • Small detail on getting_started_md corrected.
  • issue 16 solved (add a custom editor):
    - a special key in the database (user_id.db) holds the custom editor of the user
    - every time a user specifies an editor when opens a notebook, the custom editor is updated so that in the next time the user can run notebooks without specifying it.
    - when uninstalling/installing the new version, it is crucial to delete the SQLite databases (located in Appdata ->Roaming -> praxxis), otherwise, the database user_id.db won't have the new (key, values).

appdata

@msftclas
Copy link

msftclas commented Jan 4, 2020

CLA assistant check
All CLA requirements met.

@joelpires joelpires changed the title Minor Fixes - Issue 24 Issue 24 and 16 fixed Jan 4, 2020
@abertsch72 abertsch72 self-assigned this Jan 5, 2020
Copy link
Collaborator

@abertsch72 abertsch72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed 24 is fixed, thank you!

Your code for 16 works, but I don't think it's necessarily the best behavior. The original intent for 16 was to be able to select a editor for opening in the command line -- for instance, preferring nano or emacs over vim. I could see setting html or jupyter as a default being useful if that's your usual mode of operation, but since the no-args open is the command line open now, you lose the ability to open a notebook in the command line if every open rewrites that default. Maybe we should set the default command line view every time it's specified (e.g. "prax o 1 nano" rewrites the default for "prax o 1") but not change the default if we're opening in jupyter or html or ads? Or otherwise, we could keep this default-setting behavior but add arguments for command-line view. Which do you think would fit your use better?

@joelpires
Copy link
Author

image
You're right. I made a new commit with new commands "prax ce" and "prax ve" that are explained in the image above (excerpt from the new "getting_started.md").
Errors for trying to change to an ordinal or a name of an editor that is not available are also managed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants