feat: list installed browsers #34258
Closed
+162
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add new commands to list installed browsers. Solves microsoft#34183 * Add `playwright ls` command to list installed browsers in `packages/playwright-core/src/cli/commands/ls.ts`. * Add `--list` option to `npx playwright install` command in `packages/playwright-core/src/cli/commands/install.ts`. * Register the new `ls` command in the CLI program in `packages/playwright-core/src/cli/program.ts`. * Write tests for the `playwright ls` command in `packages/playwright-core/src/cli/commands/ls.test.ts`. * Add documentation for the new `playwright ls` command and `--list` option in `docs/src/cli.md`. * Update `.github/actions/run-test/action.yml` to use `npx playwright install --with-deps --list` to list installed browsers.
|
@microsoft-github-policy-service agree |
This comment has been minimized.
This comment has been minimized.
Skn0tt
requested changes
Jan 9, 2025
This comment has been minimized.
This comment has been minimized.
The git history became messed up with a merge so I'm gonna recreate this pr |
This comment has been minimized.
This comment has been minimized.
Test results for "tests 1"5 flaky37582 passed, 648 skipped Merge workflow run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List Installed Browser Command to Solve #34183
CoPilot Generated Summary:
playwright lscommand to list installed browsers inpackages/playwright-core/src/cli/commands/ls.ts.--listoption tonpx playwright installcommand inpackages/playwright-core/src/cli/commands/install.ts.lscommand in the CLI program inpackages/playwright-core/src/cli/program.ts.playwright lscommand inpackages/playwright-core/src/cli/commands/ls.test.ts.playwright lscommand and--listoption indocs/src/cli.md..github/actions/run-test/action.ymlto usenpx playwright install --with-deps --listto list installed browsers.