-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(chromium-tip-of-tree): roll to r1234 #31418
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
5bd01e5
to
f10eefe
Compare
Test results for "tests 1"8 flaky28391 passed, 649 skipped Merge workflow run. |
Test results for "tests others"2 failed 2 flaky17780 passed, 479 skipped Merge workflow run. |
Test results for "tests 2"4 fatal errors, not part of any test 93 flaky209672 passed, 9308 skipped, 1380 did not run Merge workflow run. |
// to give the browser a chance to crash. | ||
new Promise(r => setTimeout(r, 1000)) | ||
]); | ||
page.evaluate(async () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should await Promise.all()
to make sure expect()
is executed.
Closes #31362