-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow folder uploads #31165
feat: allow folder uploads #31165
Conversation
This comment has been minimized.
This comment has been minimized.
e2c518d
to
4e79b5e
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
047e30c
to
f87b89e
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
a9038d0
to
2b12702
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
dd5e822
to
3983cf9
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
packages/playwright-core/src/server/dispatchers/browserContextDispatcher.ts
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
8974a30
to
fdf130a
Compare
This comment has been minimized.
This comment has been minimized.
87752e2
to
f872891
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Test results for "tests others"2 fatal errors, not part of any test 2 flaky1 interrupted10436 passed, 353 skipped, 2318 did not run Merge workflow run. |
Test results for "tests 2"7 failed 48 flaky199829 passed, 8667 skipped Merge workflow run. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Dmitry Gozman <[email protected]> Signed-off-by: Max Schmitt <[email protected]>
Test results for "tests 1"1 flaky28317 passed, 637 skipped Merge workflow run. |
Motivation: This adds support for
input[webkitdirectory]
folder uploads. For local mode, we just pass the directory to the browser, for "remote mode" we stream the files to the server and keeping the same parent directory name. This one is also used inside the browser in thewebkitRelativePath
field in theFile
type.In Chromium headless, there is a bug, that folder uploads won't consider nested files / is this a blocker for the feature to land?
Firefox + WebKit implementation have been landed and look like they are working. Requires rolls, hence the tests are still not passing.Feature request: #6854