Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update auth.md with small improvement to C# example #30313

Merged
merged 2 commits into from
Apr 15, 2024

Conversation

thatstatsguy
Copy link
Contributor

@thatstatsguy thatstatsguy commented Apr 9, 2024

  • better indication on how to reference the newly created playwright/.auth file relative to where tests are executing

Signed-off-by: Christopher Dunderdale <[email protected]>
Signed-off-by: Christopher Dunderdale <[email protected]>
@mxschmitt
Copy link
Member

Isn't it even better to have the state.json inside the bin folder? Then the user never need to worry to add it to the gitignore file.

@thatstatsguy
Copy link
Contributor Author

true - but what I'd do for this is remove the following part of the docs for c#

create a playwright/.auth folder and add it to the git ignore

since it's actually not needed (I assumed this had to be there for it to work). I assumed playwright would somehow automatically pick up that folder in the parent folder structure for the tests.

@mxschmitt mxschmitt merged commit f7e612f into microsoft:main Apr 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants