chore: don't fail when browser is already installed #268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (code === 0) | ||
| resolve(); | ||
| resolve(`// Browser ${channel} installed`); | ||
| else if (output.includes('already installed')) |
There was a problem hiding this comment.
That's going to break over time, especially if we don't have a test.
There was a problem hiding this comment.
What'd you recommend instead?
There was a problem hiding this comment.
To make installing chrome idempotent upstream?
|
closing in favour of microsoft/playwright#35791 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some models like calling
browser_installjust to be sure. For users of channels like chrome or msedge, this call throws an error; making the model think that it can't use a browser at all!