Added CIL-GDPCIR #22
Merged
Added CIL-GDPCIR #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Copied over collections * Fixed lon / y item_asset * Fixed geoparquet asset
|
CI failure is from stac-utils/stac-fastapi#447 / our build environment not having a C compiler. |
|
@TomAugspurger the ciso8601 dependency is removed in 2.4.1, please give it a try! |
lossyrob
suggested changes
Aug 8, 2022
There was a problem hiding this comment.
We don't have the system to run integration tests on a dataset if that dataset has changed yet, but adding that would validate the collection and items once we do (and you can run them locally before the CI is set up). Can you add something like https://github.com/microsoft/planetary-computer-tasks/blob/main/datasets/io-land-cover/tests/test_dataset.py?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates the cil-gdpcir collections
Fixes microsoft/PlanetaryComputerDataCatalog#347.
How Has This Been Tested?
Still working on submitting this to test.
Checklist: