vmm_core: Remove is_mmio from CpuIo #1301
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smalis-msft
changed the title
| @@ -802,7 +802,6 @@ mod x86 { | |||
|
|
|||
| if self.intercept_state().is_some() | |||
| && self.state.active_vtl == Vtl::Vtl0 | |||
| && !dev.is_mmio(access.Gpa) | |||
There was a problem hiding this comment.
previously it would enter the 'else' and call self.emulate(...); is this going to break device emulation?
There was a problem hiding this comment.
It shouldn't, as UH should end up emulating the intercept. Slightly more overhead, but the same end result.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function is a footgun, as it doesn't capture MNF or MMIO ranges emulated elsewhere (like on the host for OpenHCL). It also only has one user. Just remove it. This will likely result in virt_whp sending more intercepts to OpenHCL instead of handling them locally, which may incur a perf penalty (hopefully not a big one), but it should not cause any functional issues (in theory 🤞).