vmbus_server: improve tracing #1027
Open
+341
−228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we want to find some kind of span-based solution rather than have common metadata that we have to remember to put in each event. |
|
Probably ideally the thing that constructs the vmbus server should create the span, since it knows the VTL and also other identifying metadata. |
lilgrassin
force-pushed
the
user/ligrassi/vmbus/add_vtl_tracing
branch
from
c7ef5bf to
8ed53dc
Compare
lilgrassin
changed the title
jstarks
reviewed
Apr 9, 2025
| @@ -1866,7 +1892,7 @@ impl<'a, N: 'a + Notifier> ServerWithNotifier<'a, N> { | |||
| | ChannelState::Revoked | |||
| | ChannelState::Reoffered | |||
| | ChannelState::ClosingClientRelease => { | |||
| tracing::error!(?offer_id, state = ?channel.state, "invalid open complete") | |||
| tracing::error!(state = ?channel.state, "Invalid channel state"); | |||
There was a problem hiding this comment.
Conventionally we start with a lowercase letter.
SvenGroot
reviewed
Apr 9, 2025
| @@ -215,28 +222,33 @@ enum ConnectionState { | |||
| Disconnecting { | |||
| next_action: ConnectionAction, | |||
| modify_sent: bool, | |||
| trace: Span, | |||
There was a problem hiding this comment.
Is there really no better way of doing this than storing this span everywhere? What is the reason we need this?
There was a problem hiding this comment.
I think I had hoped we'd just have a single root span for the vmbus server task.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the associated vtl to vmbus_server trace events to aid debugging.