consomme: ICMP support for things like ping #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benhillis
reviewed
Oct 18, 2024
sunilmut
force-pushed
the
user/sunilmut/icmp_consomme
branch
from
8434a11
to
0b65e9c
Compare
benhillis
approved these changes
Oct 25, 2024
daprilik
requested changes
Oct 25, 2024
daprilik
reviewed
Oct 25, 2024
| } | ||
| } | ||
|
|
||
| fn recv_from(socket: &mut Socket, buffer: *mut [u8]) -> std::io::Result<(usize, SockAddr)> { |
There was a problem hiding this comment.
shouldn't this take a &mut [u8] instead of a *mut [u8]?
jstarks
reviewed
Oct 25, 2024
| // with the 'net.ip.ping_group_range' configuration, which is more | ||
| // permissive. | ||
| let socket_type = if cfg!(windows) { | ||
| Type::RAW |
There was a problem hiding this comment.
What perms are required for this on Windows?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the ICMP backend handler for consomme