Skip to content

Commit

Permalink
misc: Reduce mesh and kernel logging on crashes (#262)
Browse files Browse the repository at this point in the history
See #261 for the reasoning behind this change. This removes two more
sources of logs that we don't feel are useful.
  • Loading branch information
smalis-msft authored Nov 11, 2024
1 parent a488949 commit 0445492
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 3 deletions.
8 changes: 6 additions & 2 deletions openhcl/openhcl_boot/src/main.rs
Original file line number Diff line number Diff line change
Expand Up @@ -123,8 +123,12 @@ fn build_kernel_command_line(
"panic_print=0",
// RELIABILITY: Reboot immediately on panic, no timeout.
"panic=-1",
// RELIABILITY: Print processor context information on a fatal signal.
"print_fatal_signals=1",
// RELIABILITY: Don't print processor context information on a fatal
// signal. Our crash dump collection infrastructure seems reliable, and
// this information doesn't seem useful without a dump anyways.
// Additionally it may push important logs off the end of the kmsg
// page logged by the host.
//"print_fatal_signals=0",
// RELIABILITY: Unlimited logging to /dev/kmsg from userspace.
"printk.devkmsg=on",
// RELIABILITY: Reboot using a triple fault as the fastest method.
Expand Down
2 changes: 1 addition & 1 deletion support/mesh/mesh_remote/src/unix_node.rs
Original file line number Diff line number Diff line change
Expand Up @@ -296,7 +296,7 @@ async fn run_leader(
},
Err(err) => {
if let RecvError::Error(err) = err {
tracing::warn!(
tracing::debug!(
?remote_id,
error = &err as &dyn std::error::Error,
"leader connection to remote failed"
Expand Down

0 comments on commit 0445492

Please sign in to comment.