fix, potential fix, thoughts #706
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -259,7 +258,7 @@ def run_benchmark(args, model, tokenizer, batch_size, prompt_length, generation_ | |||
| if args.use_graph_capture: | |||
| params.try_graph_capture_with_max_batch_size(batch_size) | |||
|
|
|||
| generator = og.Generator(model, params) | |||
| generator = og.Generator(model, params) # TODO: Generator allocates memory. Should we measure this? Should we add functionality so we can reuse this memory? | |||
There was a problem hiding this comment.
I think we should detect when the generator goes out of scope and release the allocator memory associated with the released generator so the memory can be reused by others.
But I think we can do it as a separate feature (and not through gc.collect which might/might not work).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.