Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean vcpkg downloads and buildtrees after building each package for Windows build #70

Merged
merged 11 commits into from
Dec 12, 2023

Conversation

abeltrano
Copy link
Contributor

@abeltrano abeltrano commented Dec 11, 2023

Type

  • Bug fix
  • Feature addition
  • Feature update
  • Documentation
  • Build Infrastructure

Side Effects

  • Breaking change
  • Non-functional change

Goals

  • Ensure the Windows build can complete successfully on a Github hosted runner.

Technical Details

  • The Github hosted runners have main drives with ~14GB free space for building a repository. Our project, specifically the gPRC dependency, generates massive buildtrees due to PDB size on Windows. As such, the vcpkg dependency build cannot complete because the runner exhausts it free disk space.
  • Enable use of the Github Action Cache for vcpkg binary caching.
  • Re-direct default vcpkg file cache to the C drive on the runner since it typically has much more space.

Test Results

  • Automated Windows build workflow now completes successfully instead of running out of space.

Reviewer Focus

  • None

Future Work

  • None

Checklist

  • Build target all compiles cleanly.
  • clang-format and clang-tidy deltas produced no new output.
  • Newly added functions include doxygen-style comment block.

@abeltrano abeltrano requested a review from a team as a code owner December 11, 2023 21:57
@abeltrano abeltrano force-pushed the fixwindowsbuildnospc branch from 67a08d1 to d51439c Compare December 12, 2023 18:24
@abeltrano abeltrano marked this pull request as draft December 12, 2023 18:56
@abeltrano abeltrano force-pushed the fixwindowsbuildnospc branch from 6ba4300 to 9786375 Compare December 12, 2023 19:42
@abeltrano abeltrano marked this pull request as ready for review December 12, 2023 19:45
@abeltrano abeltrano merged commit 92a74d3 into develop Dec 12, 2023
1 check passed
@abeltrano abeltrano deleted the fixwindowsbuildnospc branch December 12, 2023 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant