Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use proper variable for public header base directory. #69

Merged
merged 2 commits into from
Dec 11, 2023
Merged

Use proper variable for public header base directory. #69

merged 2 commits into from
Dec 11, 2023

Conversation

abeltrano
Copy link
Contributor

Type

  • Bug fix
  • Feature addition
  • Feature update
  • Documentation
  • Build Infrastructure

Side Effects

  • Breaking change
  • Non-functional change

Goals

  • Ensure the generated protobuf headers are installed.
  • Quote all installation paths.

Technical Details

  • Use NETREMOTE_DIR_INSTALL_PUBLIC_HEADER_BASE instead of the non-existent NETREMOTE_DIR_INSTALL_PUBLIC_BASE for determining where to publish generated protobuf headers.

Test Results

  • Ran CMake install with a fresh configure and validated the generated headers are present.

Reviewer Focus

  • None

Future Work

  • None

Checklist

  • Build target all compiles cleanly.
  • clang-format and clang-tidy deltas produced no new output.
  • Newly added functions include doxygen-style comment block.

@abeltrano abeltrano requested a review from a team as a code owner December 11, 2023 21:32
@abeltrano abeltrano merged commit 26ac9ad into develop Dec 11, 2023
1 of 4 checks passed
@abeltrano abeltrano deleted the fixprotoheaderpublish branch December 11, 2023 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@abeltrano